Open
Conversation
RobertJoonas
approved these changes
Apr 8, 2026
Comment on lines
+3
to
+6
| export const getMetricLabel = ( | ||
| metric: Metric, | ||
| { hasConversionGoalFilter }: { hasConversionGoalFilter: boolean } | ||
| ): string => { |
Contributor
There was a problem hiding this comment.
This signature works for replacing Top Stats, but with breakdowns in mind, I would like to propose:
type MetricLabelOverrides = {
default: Record<Metric, string>,
conversionGoalFilter: Record<Metric, string>,
realtime: Record<Metric, string>
}
export const getMetricLabel = (
metric: Metric,
dashboardState: DashboardState,
// Not sure what's best for MetricLabelOverrides:
// * an object like {default: Record<Metric, string>, conversionGoalFilter: Record<Metric, string>, realtime: ...}
// OR
// * a function (metric, dashboardState) => string
overrides: MetricLabelOverrides
): string => {...}Here are a few reasons why:
- In most goal-filtered breakdown reports,
Unique conversionsis justConversions - In entry/exit pages reports,
visitsare labelledTotal entrances/exits - In the conversions (goals breakdown) report,
visitorsis labelledUniques - ...
Not saying this should be a part of this PR, but perhaps passing dashboardState instead of {hasConversionGoalFilter} could be a better starting point?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Introduces get metric label utility. Needed for refactoring main graph. Useful when sunsetting Metrics class.
Tests
Changelog
Documentation
Dark mode